MediaPlayer Core - PMD Results

PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/openhome/net/device/tests/TestDvDevice.java

Violation	Line
Avoid empty catch blocks	33 - 36
Useless parentheses.	51

org/rpi/config/Config.java

Violation	Line
Avoid empty catch blocks	107 - 109

org/rpi/log/CustomRollingFileAppender.java

Violation	Line
Avoid unused private fields such as 'mLogHeader'.	25
Useless parentheses.	97
Avoid unused local variables such as '_tmp'.	131
Useless parentheses.	176

org/rpi/main/SimpleDevice.java

Violation	Line
Avoid unused imports such as 'java.io.BufferedReader'	4
Avoid unused imports such as 'java.io.InputStreamReader'	9
Avoid unused imports such as 'java.net.InetAddress'	10
Avoid unused imports such as 'java.util.regex.Matcher'	14
Avoid unused imports such as 'java.util.regex.Pattern'	15
Avoid empty catch blocks	280 - 282
Avoid unused private methods such as 'writeFile(String)'.	447

org/rpi/mpdplayer/MPDPlayer.java

Violation	Line
Avoid unused imports such as 'org.rpi.player.events.EventMuteChanged'	13
Avoid empty if statements	236 - 238

org/rpi/mpdplayer/MPDPlayerController.java

Violation	Line
Avoid unused private fields such as 'log'.	18
Avoid unused local variables such as 'e'.	98

org/rpi/mpdplayer/StatusMonitor.java

Violation	Line
These nested if statements could be combined	82 - 84
These nested if statements could be combined	112 - 118
These nested if statements could be combined	113 - 117
These nested if statements could be combined	123 - 129
Avoid empty catch blocks	178 - 180
Avoid empty catch blocks	188 - 190

org/rpi/mpdplayer/TCPConnector.java

Violation	Line
Avoid empty catch blocks	82 - 84
Avoid empty catch blocks	200 - 202
Avoid empty catch blocks	229 - 231

org/rpi/mplayer/InputWriter.java

Violation	Line
These nested if statements could be combined	30 - 45

org/rpi/mplayer/MPlayer.java

Violation	Line
Avoid unused private fields such as 'bPlaying'.	28
These nested if statements could be combined	217 - 219

org/rpi/mplayer/OutputReader.java

Violation	Line
These nested if statements could be combined	164 - 166

org/rpi/mplayer/PositionThread.java

Violation	Line
Avoid unused private fields such as 'bNewTrack'.	9

org/rpi/mplayer/StartMPlayer.java

Violation	Line
Avoid empty if statements	37 - 40
Avoid empty if statements	42 - 44

org/rpi/mplayer/TrackInfo.java

Violation	Line
Avoid unused imports such as 'org.rpi.player.IPlayer'	5

org/rpi/os/OSManager.java

Violation	Line
Useless parentheses.	114
Useless parentheses.	271
Useless parentheses.	273
Avoid empty if statements	325 - 326

org/rpi/player/CommandTracker.java

Violation	Line
These nested if statements could be combined	26 - 32

org/rpi/player/IPlayer.java

Violation	Line
Avoid modifiers which are implied by the context	14
Avoid modifiers which are implied by the context	15
Avoid modifiers which are implied by the context	18
Avoid modifiers which are implied by the context	19
Avoid modifiers which are implied by the context	20
Avoid modifiers which are implied by the context	21
Avoid modifiers which are implied by the context	22
Avoid modifiers which are implied by the context	23
Avoid modifiers which are implied by the context	24
Avoid modifiers which are implied by the context	25
Avoid modifiers which are implied by the context	28
Avoid modifiers which are implied by the context	29
Avoid modifiers which are implied by the context	33
Avoid modifiers which are implied by the context	34
Avoid modifiers which are implied by the context	35
Avoid modifiers which are implied by the context	36
Avoid modifiers which are implied by the context	39
Avoid modifiers which are implied by the context	42

org/rpi/player/IPlayerController.java

Violation	Line
Avoid modifiers which are implied by the context	13
Avoid modifiers which are implied by the context	14
Avoid modifiers which are implied by the context	17
Avoid modifiers which are implied by the context	18
Avoid modifiers which are implied by the context	21
Avoid modifiers which are implied by the context	22
Avoid modifiers which are implied by the context	23
Avoid modifiers which are implied by the context	25
Avoid modifiers which are implied by the context	27
Avoid modifiers which are implied by the context	28
Avoid modifiers which are implied by the context	30
Avoid modifiers which are implied by the context	31
Avoid modifiers which are implied by the context	33
Avoid modifiers which are implied by the context	34
Avoid modifiers which are implied by the context	36

org/rpi/player/IPlayerEventClassListener.java

Violation	Line
Avoid modifiers which are implied by the context	6

org/rpi/player/PlayManager.java

Violation	Line
Avoid duplicate imports such as 'org.rpi.player.observers.ObservableTime'	31
Avoid unused private fields such as 'status'.	65
Useless parentheses.	146
Avoid empty if statements	165 - 167
Useless parentheses.	198
These nested if statements could be combined	318 - 324
Useless parentheses.	360
These nested if statements could be combined	567 - 570
These nested if statements could be combined	612 - 613
These nested if statements could be combined	638 - 639
These nested if statements could be combined	755 - 759
These nested if statements could be combined	756 - 758
These nested if statements could be combined	784 - 792
These nested if statements could be combined	933 - 944
Avoid empty catch blocks	966 - 968

org/rpi/player/events/EventBase.java

Violation	Line
Avoid modifiers which are implied by the context	8

org/rpi/player/observers/ObservableAVTransport.java

Violation	Line
Avoid empty catch blocks	18 - 20

org/rpi/player/observers/ObservableInfo.java

Violation	Line
Avoid empty catch blocks	25 - 27

org/rpi/player/observers/ObservablePlayList.java

Violation	Line
Avoid empty catch blocks	25 - 27

org/rpi/player/observers/ObservableProduct.java

Violation	Line
Avoid empty catch blocks	24 - 26

org/rpi/player/observers/ObservableRadio.java

Violation	Line
Avoid empty catch blocks	24 - 26

org/rpi/player/observers/ObservableTime.java

Violation	Line
Avoid unused local variables such as 's'.	28

org/rpi/player/observers/ObservableVolume.java

Violation	Line
Avoid empty catch blocks	24 - 26

org/rpi/playlist/CustomTrack.java

Violation	Line
Avoid unused local variables such as 'role_type'.	151
Avoid empty if statements	155 - 157
Avoid empty catch blocks	275 - 277
These nested if statements could be combined	399 - 409
These nested if statements could be combined	401 - 408

org/rpi/playlist/PlayListReader.java

Violation	Line
No need to import a type that lives in the same package	8
Avoid unused local variables such as 'duration'.	56

org/rpi/plugingateway/PluginGateWay.java

Violation	Line
Avoid unused private fields such as 'log'.	15

org/rpi/providers/PrvAVTransport.java

Violation	Line
Avoid unused private methods such as 'createEventState()'.	64
Avoid empty catch blocks	250 - 252
Useless parentheses.	296
Avoid empty if statements	302 - 305
Avoid unnecessary temporaries when converting primitives to Strings	425

org/rpi/providers/PrvConnectionManager.java

Violation	Line
Avoid unused private fields such as 'iConnectionID'.	21

org/rpi/providers/PrvInfo.java

Violation	Line
Avoid unused private fields such as 'meta_text_id'.	23

org/rpi/providers/PrvProduct.java

Violation	Line
Avoid unused private fields such as 'iPlayer'.	42
Avoid unused private methods such as 'initSources()'.	113

org/rpi/providers/PrvRadio.java

Violation	Line
Avoid unused local variables such as 'c'.	257

org/rpi/providers/PrvReceiver.java

Violation	Line
Avoid unused private fields such as 'bPlay'.	15
Avoid unused private fields such as 'track'.	16

org/rpi/providers/PrvRenderingControl.java

Violation	Line
Avoid unused private methods such as 'updateVolume()'.	343
Avoid unused private methods such as 'updateMute()'.	356

org/rpi/providers/PrvVolume.java

Violation	Line
Avoid unused local variables such as 'volume'.	95
Avoid unused local variables such as 'volume'.	105

org/rpi/radio/ChannelReader.java

Violation	Line
Useless parentheses.	155

org/rpi/radio/CustomChannel.java

Violation	Line
Avoid unused private fields such as 'log'.	8
Avoid unused private fields such as 'title'.	24
Overriding method merely calls super	100 - 102

org/rpi/radio/parsers/FileParser.java

Violation	Line
Useless parentheses.	52
Useless parentheses.	62
Useless parentheses.	106
Useless parentheses.	113
Useless parentheses.	128

org/rpi/radio/parsers/TestParsers.java

Violation	Line
Avoid unused local variables such as 'pls'.	12
Avoid unused local variables such as 'm3u'.	14

org/rpi/songcast/OHMessage.java

Violation	Line
Avoid unused imports such as 'java.nio.ByteBuffer'	4
Avoid unused imports such as 'java.util.Arrays'	5
Useless parentheses.	36
Useless parentheses.	40
Avoid empty catch blocks	43 - 45

org/rpi/songcast/SongcastMessage.java

Violation	Line
Useless parentheses.	16
Useless parentheses.	43
Useless parentheses.	64

org/rpi/songcast/UDPReceiver.java

Violation	Line
Avoid unused imports such as 'java.net.InetSocketAddress'	6
Avoid unused imports such as 'java.util.Enumeration'	10
Do not hard code the IP address	41
Do not hard code the IP address	59

org/rpi/songcast/UDPSender.java

Violation	Line
Avoid unused imports such as 'java.net.DatagramSocket'	5
Avoid unused imports such as 'java.net.InetSocketAddress'	7
Avoid unused imports such as 'java.net.SocketAddress'	10
Avoid unused imports such as 'java.net.UnknownHostException'	11
Avoid unused private fields such as 'zoneID'.	25
Do not hard code the IP address	36

org/rpi/sources/SourceReader.java

Violation	Line
Avoid unused local variables such as 'i'.	45
These nested if statements could be combined	65 - 68
Avoid unused private methods such as 'setSources(ConcurrentHashMap)'.	115

org/rpi/utils/NetworkUtils.java

Violation	Line
Useless parentheses.	43

org/rpi/utils/Utils.java

Violation	Line
Avoid empty catch blocks	30 - 31
Useless parentheses.	36
Useless parentheses.	36
Useless parentheses.	36
Useless parentheses.	36